This repository was archived by the owner on Sep 8, 2025. It is now read-only.
feat: adds support for dark/light mode for the three dots button#1544
Open
jonybur wants to merge 3 commits into
Open
feat: adds support for dark/light mode for the three dots button#1544jonybur wants to merge 3 commits into
jonybur wants to merge 3 commits into
Conversation
jonybur
commented
Sep 4, 2025
jonybur
commented
jonybur
requested review from
gbarkhatov,
jeremy-babylonlabs and
jrwbabylonlab
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds dark/light mode support for the three dots button by conditionally rendering different SVG icons based on the current theme. The implementation uses next-themes to detect the current theme and prevents hydration mismatches with a mounting state.
Key changes:
- Imports two SVG assets for light and dark themes
- Adds theme detection and mounting state management
- Conditionally renders the appropriate icon based on the resolved theme
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jeremy-babylonlabs
left a comment
jeremy-babylonlabs
left a comment
Contributor
There was a problem hiding this comment.
Why not implement it like the other svg in core-ui?
jrwbabylonlab
previously approved these changes
Sep 5, 2025
jeremy-babylonlabs
approved these changes
Sep 5, 2025
jrwbabylonlab
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.